feat(@schematics/angular): rely on strict template default in generated workspaces#32824
feat(@schematics/angular): rely on strict template default in generated workspaces#32824alan-agius4 merged 2 commits intoangular:mainfrom
Conversation
alan-agius4
added
action: review
angular-robot
Bot
added
detected: feature
…ed workspaces Since strict templates are now the default in the Angular compiler, this change removes the explicit "strictTemplates": true setting when creating a new strict workspace. We now only explicitly set "strictTemplates": false when the workspace is created with --strict=false to maintain consistent behavior for non-strict setups. See: angular/angular#67802
alan-agius4
force-pushed
the
strict-template
branch
from
caa6a7a to
ba5fe7b
Compare
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request correctly updates the tsconfig.json.template to reflect the Angular compiler's new default behavior for strictTemplates. It removes the explicit strictTemplates: true setting when a strict workspace is generated, and instead explicitly sets strictTemplates: false only when --strict=false is provided. The associated test cases in index_spec.ts have been updated to align with these changes. I've identified an opportunity to improve the test coverage for the strict: true scenario by adding assertions for other angularCompilerOptions that are explicitly set.
…generated workspaces
alan-agius4
added
action: merge
|
This PR was merged into the repository. The changes were merged into the following branches:
|
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
2 participants
Since strict templates are now the default in the Angular compiler, this change removes the explicit "strictTemplates": true setting when creating a new strict workspace. We now only explicitly set "strictTemplates": false when the workspace is created with --strict=false to maintain consistent behavior for non-strict setups.
See: angular/angular#67802